Respect GUIDELLM__PREFERRED_ROUTE during backend validation #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Build Artifacts Available |
markurtz
approved these changes
Jul 10, 2025
DaltheCow
pushed a commit
that referenced
this pull request
Jul 15, 2025
`Backend.validate()` always issued a smoke-test call to the legacy /v1/completions endpoint, even when the caller specified `GUIDELLM__PREFERRED_ROUTE=chat_completions`. This breaks validation against deployments that expose only the chat-completions route. The PR makes backend validation honor the `GUIDELLM__PREFERRED_ROUTE` setting. Instead of always using the /v1/completions endpoint, it now chooses between text_completions and chat_completions based on the configured preference. Signed-off-by: dalthecow <[email protected]>
DaltheCow
pushed a commit
that referenced
this pull request
Jul 15, 2025
`Backend.validate()` always issued a smoke-test call to the legacy /v1/completions endpoint, even when the caller specified `GUIDELLM__PREFERRED_ROUTE=chat_completions`. This breaks validation against deployments that expose only the chat-completions route. The PR makes backend validation honor the `GUIDELLM__PREFERRED_ROUTE` setting. Instead of always using the /v1/completions endpoint, it now chooses between text_completions and chat_completions based on the configured preference. Signed-off-by: dalthecow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend.validate()always issued a smoke-test call to the legacy /v1/completions endpoint, even when the caller specifiedGUIDELLM__PREFERRED_ROUTE=chat_completions. This breaks validation against deployments that expose only the chat-completions route.The PR makes backend validation honor the
GUIDELLM__PREFERRED_ROUTEsetting. Instead of always using the /v1/completions endpoint, it now chooses between text_completions and chat_completions based on the configured preference.