[core][executor] simplify instance id #10976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
youkaichao
requested review from
zhuohan123,
alexm-redhat,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
tlrmchlsmth
approved these changes
Dec 7, 2024
tlrmchlsmth
reviewed
Dec 7, 2024
kzawora-intel
added a commit
to HabanaAI/vllm-hpu-extension
that referenced
this pull request
Dec 9, 2024
get_vllm_instance_id was removed in vllm-project/vllm#10976. This PR removes the dependency on that function.
kzawora-intel
added a commit
to HabanaAI/vllm-hpu-extension
that referenced
this pull request
Dec 9, 2024
* Remove get_vllm_instance_id dependency get_vllm_instance_id was removed in vllm-project/vllm#10976. This PR removes the dependency on that function. * Update profiler.py
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: youkaichao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance id will be attached to the vllm_config object instead of passing by env var.