Skip to content

Conversation

hongxiayang
Copy link
Collaborator

@hongxiayang hongxiayang commented Feb 2, 2025

Thanks for great work from vLLM community to enable DeepSeek model.
This PR is to use the Triton MLA backend on ROCm to enable DeepSeek model on AMD GPUs.

Tests:

  • Tested on DeepSeek V2 (DeepSeek-Coder-V2-Lite-Instruct) model on MI300x and MI210.
  • Tested on DeepSeek V3 dummy weights on MI300x.
  • Added two unit tests.

Note: to use DeepSeek model, we should ensure to have the "trust_remote_code" flag on.

Copy link

github-actions bot commented Feb 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

mawong-amd and others added 2 commits February 2, 2025 11:10
Signed-off-by: Hongxia Yang <[email protected]>
Signed-off-by: Hongxia Yang <[email protected]>
@hongxiayang hongxiayang marked this pull request as ready for review February 2, 2025 18:27
@hongxiayang hongxiayang added ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm labels Feb 3, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you able to add DeepSeek-Coder-V2-Lite-Instruct as a model test for the AMD runner with a check that TritonMLA is chosen for the attention module?

….py has to be ignored today

Signed-off-by: Hongxia Yang <[email protected]>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mgoin mgoin enabled auto-merge (squash) February 4, 2025 01:32
@hongxiayang
Copy link
Collaborator Author

LGTM! Would you able to add DeepSeek-Coder-V2-Lite-Instruct as a model test for the AMD runner with a check that TritonMLA is chosen for the attention module?

@mgoin

Thank you

@mgoin Thank your for your review and approval.

@mgoin mgoin merged commit c36ac98 into vllm-project:main Feb 4, 2025
54 checks passed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants