[WIP] Download lora from modelscope when VLLM_USE_MODELSCOPE is true #13220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #6234
With #6234, we can donwload the loras dynamically from HF, however, once people set the environment
VLLM_USE_MODELSCOPE=true
, we should download the loras from MS as well.It's counterintuitive to download the model from one hub, but lora from another hub.
If this is acceptable, I'll continue the work, like adding tests. cc @Jeffwan @Yard1 as the original author and reviewer.