Skip to content

[Bugfix] Handle content type with optional parameters #13383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

[Bugfix] Handle content type with optional parameters #13383

merged 3 commits into from
Feb 18, 2025

Conversation

zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Feb 17, 2025 •
edited by github-actions bot
Loading

Content type is allowed to have multiple optional parameters, e.g. application/json; charset=UTF-8. It's not correctly handled right now.

Follow-up of #13193.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@zifeitong
Handle content type with optional parameters
6556233 
e.g. application/json; charset=UTF-8

Signed-off-by: Zifei Tong <[email protected]>
@zifeitong zifeitong force-pushed the fix_content_type_check branch from 45b787d to 6556233 Compare February 17, 2025 07:41
@mergify mergify bot added the frontend label Feb 17, 2025
@zifeitong
Should be semicolon
e7552b8 
Signed-off-by: Zifei Tong <[email protected]>
DarkLight1337
DarkLight1337 reviewed Feb 17, 2025
View reviewed changes
@zifeitong
Add maxsplit
0a87e6c 
Signed-off-by: Zifei Tong <[email protected]>
@DarkLight1337
Copy link
Member

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 06:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@DarkLight1337 DarkLight1337 merged commit d3231cb into vllm-project:main Feb 18, 2025
58 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@zifeitong
[Bugfix] Handle content type with optional parameters (vllm-project#1…
9f84544 
…3383)

Signed-off-by: Zifei Tong <[email protected]>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@zifeitong @Akshat-Tripathi
[Bugfix] Handle content type with optional parameters (vllm-project#1…
7482ce2 
…3383)

Signed-off-by: Zifei Tong <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@zifeitong @lulmer
[Bugfix] Handle content type with optional parameters (vllm-project#1…
0fff7b5 
…3383)

Signed-off-by: Zifei Tong <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@zifeitong @shreyankg
[Bugfix] Handle content type with optional parameters (vllm-project#1…
b88ba08 
…3383)

Signed-off-by: Zifei Tong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@cjackal cjackal cjackal left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zifeitong @DarkLight1337 @cjackal