Skip to content

Conversation

dtrifiro
Copy link
Contributor

#8772 migrated static metadata to pyproject.toml, but had the unintended consequence of not creating the vllm/_version.py at build time.

@dtrifiro dtrifiro force-pushed the force-writing-version-file branch from 9b5890d to 06d19cb Compare February 19, 2025 10:37
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 19, 2025
@dtrifiro
Copy link
Contributor Author

@simon-mo this is a follow up o #8772, which we urgently need to unbreak the build

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 19, 2025 10:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@youkaichao youkaichao disabled auto-merge February 19, 2025 10:47
@youkaichao
Copy link
Member

confirmed it works from the neuron test. thanks for the fix!

@youkaichao youkaichao merged commit 81dabf2 into vllm-project:main Feb 19, 2025
13 of 18 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Daniele Trifirò <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants