Skip to content

Conversation

njhill
Copy link
Member

@njhill njhill commented Feb 19, 2025

Introduced by #13060.

Exception in thread Thread-3 (process_outputs_socket):
Traceback (most recent call last):
  File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
  File "/data/woosuk/workspace/vllm/vllm/v1/engine/core_client.py", line 256, in process_outputs_socket
    (frame, ) = output_socket.recv_multipart(copy=False)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/site-packages/zmq/sugar/socket.py", line 808, in recv_multipart
    parts = [self.recv(flags, copy=copy, track=track)]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "_zmq.py", line 1156, in zmq.backend.cython._zmq.Socket.recv
  File "_zmq.py", line 1193, in zmq.backend.cython._zmq.Socket.recv
  File "_zmq.py", line 1258, in zmq.backend.cython._zmq._recv_frame
  File "_zmq.py", line 175, in zmq.backend.cython._zmq._check_rc
zmq.error.ContextTerminated: Context was terminated

@njhill njhill added bug Something isn't working v1 labels Feb 19, 2025
@njhill njhill changed the title [BugFix] Avoid error traceback in logs when V1 LLM terminates [BugFix] Avoid error traceback in logs when V1 LLM terminates Feb 19, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@WoosukKwon
Copy link
Collaborator

Works on my machine!

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@njhill njhill enabled auto-merge (squash) February 19, 2025 21:58
@njhill njhill merged commit a4c402a into vllm-project:main Feb 20, 2025
59 checks passed
@njhill njhill deleted the zmq-ctx-shutdown-err branch February 20, 2025 01:07
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants