Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 21, 2025

This is a follow-up of #13068 to fix:

  • Handle the inf qps config. The JSON parser used by the database doesn't like this value. So, I add a custom InfEncoder to convert this to an inf string.
  • Passing the parameter --tensor-parallel-size to benchmark_serving.py script so that it can be stored in JSON and picked up by the dashboard. I'll use --metadata to get this instead per @ywang96 comment
  • Handle missing .commands because the new .pytorch.json is also a JSON file.

cc @ywang96 @simon-mo

Just FYI, here is a preview of the new dashboard.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Comment on lines 1328 to 1334
parser.add_argument(
"--tensor-parallel-size",
type=int,
default=0,
help=
"The tensor parallel used by the server to display on the dashboard")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just need a way to pass tp as an argument to this script, we already have --metadata

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it, --metadata is indeed more appropriate for this as I just need to get tp parameter to show on the dashboard. It's probably a good idea to save other server parameters too just in case.

@huydhn huydhn requested a review from ywang96 February 23, 2025 03:43
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix and addressing my comment!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 23, 2025
@DarkLight1337 DarkLight1337 merged commit e7ef74e into vllm-project:main Feb 24, 2025
39 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants