Skip to content

[Bugfix] Revert inspection code in #13743 #13832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

[Bugfix] Revert inspection code in #13743 #13832

merged 1 commit into from
Feb 25, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 25, 2025 •
edited
Loading

The model inspection code in #13743 causes infinite recursion when called in a plugin because inspecting the model in another subprocess loads all general plugins in that subprocess as well.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

youkaichao
youkaichao approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, manually verified it works

@youkaichao youkaichao merged commit f4133ce into vllm-project:main Feb 25, 2025
13 of 17 checks passed
@DarkLight1337 DarkLight1337 deleted the partial-revert-13743 branch February 25, 2025 16:19
@youkaichao youkaichao mentioned this pull request Feb 26, 2025
Merged
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@DarkLight1337 @Akshat-Tripathi
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
d8265fd 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
fd90602 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
6ddc011 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkLight1337 @youkaichao