[VLM] Generalized prompt updates for multi-modal processor #13964
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
added
the
ready
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
changed the title
PromptInsertion as a type of prompt update
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
changed the title
PromptInsertion as a type of prompt update
| return PromptUpdateDetails( | ||
| full=image_tokens + [bos_token_id], | ||
| features=image_tokens, | ||
| ) |
There was a problem hiding this comment.
We can also use PromptInsertion for Fuyu.
There was a problem hiding this comment.
It doesn't quite work for Fuyu because it replaces eot_token_id with bos_token_id.
There was a problem hiding this comment.
Let me try regardless and see if the test still passes. Yep, doesn't work.
…ect#13964) Signed-off-by: DarkLight1337 <[email protected]>
…ect#13964) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…ect#13964) Signed-off-by: DarkLight1337 <[email protected]>
This PR generalizes
PromptReplacementtoPromptUpdate, and introduces a new type of update,PromptInsertion, that inserts placeholder tokens without having to replace anything in the string.This should simplify the implementation of #13584
Multi-image support for Molmo will be worked on in another PR.
Deprecation:
_get_prompt_replacementshas been renamed to_get_prompt_updates.