Skip to content

Conversation

congcongchen123
Copy link
Contributor

@congcongchen123 congcongchen123 commented Mar 5, 2025

Now with Phi-4-multimodal-instruct merged into main, we would like to have another PR to address the high latency overhead we have observed for Phi4-multimod when using LoRA.

Benchmark results with this PR:
ttft: time to first token (in seconds)
tbt: time between token (in seconds)
image

Copy link

github-actions bot commented Mar 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee
Copy link
Collaborator

Thanks for your contribution, have you tested the performance of autotune on models like llama?

@congcongchen123
Copy link
Contributor Author

congcongchen123 commented Mar 5, 2025

Thanks for your contribution, have you tested the performance of autotune on models like llama?

Nope, I am not familiar with the llama family of models that use LoRA. Do you know any of those?

@lhcavalcanti
Copy link

@DarkLight1337 could you take a look in this one?

Thanks!

@jeejeelee
Copy link
Collaborator

@DarkLight1337 DarkLight1337 requested a review from jeejeelee March 6, 2025 06:21
@DarkLight1337
Copy link
Member

I'll hand it over to @jeejeelee as he is more familiar with these kernels.

@amarflybot
Copy link

Hi @congcongchen123 Could you please rebase these changes from master again ? I think the files are no longer existing.

Copy link

mergify bot commented Jun 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @congcongchen123.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jun 8, 2025
Copy link

github-actions bot commented Sep 7, 2025

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase stale Over 90 days of inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants