Skip to content

[Bugfix] embed_is_patch for Idefics3 #15696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

[Bugfix] embed_is_patch for Idefics3 #15696

merged 4 commits into from
Mar 28, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 28, 2025 •
edited by github-actions bot
Loading

Address #15144 for Idefics3 model. The model correctness tests pass locally for both V0 and V1.

I also found some unused torch.utils.checkpoint imports so I have removed them from various model files.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 28, 2025 10:23
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Mar 28, 2025
Closed
5 tasks
@DarkLight1337 DarkLight1337 changed the title [Bugfix] embed is patch for Idefics3 [Bugfix] embed_is_patch for Idefics3 Mar 28, 2025
@DarkLight1337
Fix
c5cf71a 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Remove redundant check
340c1a7 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 28, 2025 14:25
@vllm-bot vllm-bot merged commit 541d1df into vllm-project:main Mar 28, 2025
32 of 36 checks passed
@DarkLight1337 DarkLight1337 deleted the idefics3-embed-is-patch branch March 28, 2025 15:27
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@DarkLight1337 @Alex4210987
[Bugfix] embed_is_patch for Idefics3 (vllm-project#15696)
4f8f7a6 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Bugfix] embed_is_patch for Idefics3 (vllm-project#15696)
389e8cc 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] embed_is_patch for Idefics3 (vllm-project#15696)
d91d932 
Signed-off-by: DarkLight1337 <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Bugfix] embed_is_patch for Idefics3 (vllm-project#15696)
2d81ada 
Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] embed_is_patch for Idefics3 (vllm-project#15696)
861ccc9 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot