Skip to content

Conversation

kebe7jun
Copy link
Contributor

@kebe7jun kebe7jun commented Apr 8, 2025

Follow #13839

Previously, the PP Layers partition information and prompts were divided into two lines, which was a bit confusing for users. It would be clearer to put them in one line. Slack discuss

Copy link

github-actions bot commented Apr 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@kebe7jun kebe7jun force-pushed the fix/pp-partition-log-unify branch from 9c851d1 to c4abdbc Compare April 8, 2025 02:21
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM. Please address the CI failure.

@jeejeelee jeejeelee added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Apr 8, 2025
@kebe7jun kebe7jun force-pushed the fix/pp-partition-log-unify branch from c4abdbc to 07b9125 Compare April 8, 2025 04:49
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) April 8, 2025 05:06
@vllm-bot vllm-bot merged commit b4ac449 into vllm-project:main Apr 8, 2025
58 of 63 checks passed
@kebe7jun kebe7jun deleted the fix/pp-partition-log-unify branch April 8, 2025 07:29
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants