Support Min P Sampler #1642
Merged
Support Min P Sampler #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
reviewed
Nov 16, 2023
|
@zhuohan123 Thanks for you reviews! In terms of first problem, i removed the |
zhuohan123
approved these changes
Nov 18, 2023
yxl
pushed a commit
to yxl/vllm
that referenced
this pull request
Nov 29, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
oobabooga/text-generation-webui#4449
ggml-org/llama.cpp#3841
It seems sample better result than normal top_k/top_p method. And i tested min_p = 0.05 when inferencing code LLM, it gave me a better explanation.