Skip to content

[Misc] Remove qlora_adapter_name_or_path #17699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 7, 2025
Merged

[Misc] Remove qlora_adapter_name_or_path #17699

merged 8 commits into from
May 7, 2025

Conversation

jeejeelee
Copy link
Collaborator

qlora_adapter_name_or_path is a redundant argument and is now deprecated

@jeejeelee
Done
8d33530 
Signed-off-by: Jee Jee Li <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 6, 2025
@jeejeelee jeejeelee requested a review from DarkLight1337 May 6, 2025 07:21
@jeejeelee
Done
5e7ec08 
Signed-off-by: Jee Jee Li <[email protected]>
DarkLight1337
DarkLight1337 reviewed May 6, 2025
View reviewed changes
@jeejeelee
Fix typo
77e2a28 
Signed-off-by: Jee Jee Li <[email protected]>
DarkLight1337
DarkLight1337 reviewed May 6, 2025
View reviewed changes
jeejeelee added 2 commits May 6, 2025 07:45
@jeejeelee
Modify comment
20a4683 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Modify comment
f934ce8 
Signed-off-by: Jee Jee Li <[email protected]>
DarkLight1337
DarkLight1337 reviewed May 6, 2025
View reviewed changes
@DarkLight1337
Copy link
Member

LGTM then

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 6, 2025
hmellor
hmellor reviewed May 6, 2025
View reviewed changes
vllm/engine/arg_utils.py
Comment on lines 514 to 520
load_group.add_argument(
"--qlora-adapter-name-or-path",
type=str,
default=None,
help="The `--qlora-adapter-name-or-path` has no effect, do not set"
" it, and it will be removed in v0.10.0.",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also add deprecated=True here (you'd probably need to merge from main though)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

vllm/model_executor/model_loader/weight_utils.py Outdated

else:
model_name_or_path = model_config.model
model_name_or_path = model_config.model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable necessary at all now? We access the other attributes from model_config directly everywhere else in this method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jeejeelee
Fix bug
8b69068 
Signed-off-by: Jee Jee Li <[email protected]>
@mergify mergify bot added the ci/build label May 6, 2025
@jeejeelee
Revert test.txt
c2b467a 
Signed-off-by: Jee Jee Li <[email protected]>
hmellor
hmellor approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeejeelee
Copy link
Collaborator Author

@hmellor It looks like we can't add deprecated=True, see: https://buildkite.com/vllm/ci/builds/19389#0196a552-9af7-4bcc-9835-0d684e85cc46

@hmellor
Copy link
Member

hmellor commented May 6, 2025

Oh, sorry about that, I thought #17426 had merged

@jeejeelee
Copy link
Collaborator Author

It doesn't matter, let's wait for #17426

@hmellor
Copy link
Member

hmellor commented May 6, 2025

Ok it's merged

@DarkLight1337
Copy link
Member

I'll just force merge this

@vllm-bot vllm-bot merged commit ba7703e into vllm-project:main May 7, 2025
52 of 55 checks passed
@jeejeelee jeejeelee deleted the move-qlora branch May 8, 2025 08:36
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@jeejeelee
[Misc] Remove qlora_adapter_name_or_path (vllm-project#17699)
6c6e638 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@jeejeelee @mawong-amd
[Misc] Remove qlora_adapter_name_or_path (vllm-project#17699)
054303e 
Signed-off-by: Jee Jee Li <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@jeejeelee
[Misc] Remove qlora_adapter_name_or_path (vllm-project#17699)
c6c10e6 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@jeejeelee @minpeter
[Misc] Remove qlora_adapter_name_or_path (vllm-project#17699)
a4d3bd8 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeejeelee @DarkLight1337 @hmellor @vllm-bot