Skip to content

[Frontend] deprecate --device arg #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

[Frontend] deprecate --device arg #18399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/source/getting_started/installation/gpu/xpu.inc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ XPU platform supports **tensor parallel** inference/serving and also supports **
python -m vllm.entrypoints.openai.api_server \
--model=facebook/opt-13b \
--dtype=bfloat16 \
--device=xpu \
--max_model_len=1024 \
--distributed-executor-backend=ray \
--pipeline-parallel-size=2 \
Expand Down
6 changes: 5 additions & 1 deletion vllm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2201,7 +2201,11 @@ class DeviceConfig:
"""Configuration for the device to use for vLLM execution."""

device: Union[Device, torch.device] = "auto"
"""Device type for vLLM execution."""
"""Device type for vLLM execution.
This parameter is deprecated and will be
removed in a future release.
It will now be set automatically based
on the current platform."""
device_type: str = field(init=False)
"""Device type from the current platform. This is set in
`__post_init__`."""
Expand Down
6 changes: 4 additions & 2 deletions vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,9 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
title="DeviceConfig",
description=DeviceConfig.__doc__,
)
device_group.add_argument("--device", **device_kwargs["device"])
device_group.add_argument("--device",
**device_kwargs["device"],
deprecated=True)

# Speculative arguments
speculative_group = parser.add_argument_group(
Expand Down Expand Up @@ -977,7 +979,7 @@ def create_engine_config(
from vllm.platforms import current_platform
current_platform.pre_register_and_update()

device_config = DeviceConfig(device=self.device)
device_config = DeviceConfig(device=current_platform.device_type)
model_config = self.create_model_config()

# * If VLLM_USE_V1 is unset, we enable V1 for "supported features"
Expand Down