Skip to content

Conversation

dtrifiro
Copy link
Contributor

The regex module requirement introduced in #18454 broke the ROCm build

Signed-off-by: Daniele Trifirò [email protected]

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 30, 2025 07:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 30, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@dtrifiro
Copy link
Contributor Author

@DarkLight1337 please consider #18945 as well, I'd rather get that in rather than this hotfix

@DarkLight1337 DarkLight1337 disabled auto-merge May 30, 2025 08:06
@DarkLight1337
Copy link
Member

OK let's see if #18945 works

@dtrifiro
Copy link
Contributor Author

Closed in favour of #18945

@dtrifiro dtrifiro closed this May 30, 2025
@dtrifiro dtrifiro deleted the fix-rocm-build branch May 30, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants