Skip to content

Conversation

b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Jun 24, 2025

I think it was added in #19463? I'm guessing its vllm FA. Just happened to see it randomly. I've definitely done this before too 😅

Signed-off-by: Brayden Zhong <[email protected]>
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) June 24, 2025 20:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 24, 2025
@WoosukKwon WoosukKwon disabled auto-merge June 24, 2025 20:22
@WoosukKwon WoosukKwon merged commit ead3698 into vllm-project:main Jun 24, 2025
12 of 20 checks passed
@b8zhong b8zhong deleted the fix/rando branch July 6, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants