-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Misc] Small: Remove global media connector. Each test should have its own test connector object. #20395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Small: Remove global media connector. Each test should have its own test connector object. #20395
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @huachenheli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant refactoring effort to improve the design of media handling within the project's examples and test suite. It moves away from a problematic global state for media connectors, instead adopting a pattern where each module manages its own MediaConnector
instance. This change directly contributes to enhanced test isolation, reduced coupling, and a cleaner, more maintainable codebase.
Highlights
- Refactoring Global State: The pull request eliminates the use of a globally shared
global_media_connector
instance, addressing a 'code smell' and promoting better architectural practices. - Enhanced Test and Example Isolation: Each test file and example script now instantiates its own dedicated
MediaConnector
object (e.g.,OFFLINE_MEDIA_CONNECTOR
orTEST_MEDIA_CONNECTOR
). This ensures that media fetching operations are isolated, preventing potential side effects and improving the reliability of tests. - Improved Code Maintainability: By replacing direct calls to global
fetch_image
,fetch_audio
, andfetch_video
utility functions with method calls on specificMediaConnector
instances, the code becomes more modular, readable, and easier to maintain and extend in the future.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the codebase to remove the global media_connector
, improving test isolation and code clarity. Each example and test file now instantiates its own MediaConnector
. Formatting suggestions have been made to improve readability.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <[email protected]>
15dc015
to
c97653d
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <[email protected]>
a921878
to
51b4c77
Compare
…s own test connector object. (vllm-project#20395) Signed-off-by: Chenheli Hua <[email protected]>
…s own test connector object. (vllm-project#20395) Signed-off-by: Chenheli Hua <[email protected]>
…s own test connector object. (vllm-project#20395) Signed-off-by: Chenheli Hua <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Summary:
Exposing a globally shared
global_media_connector
instance just for test & example purposes is code smell. This PR removes it and instead has each test case keep its ownMediaConnector
instance for better test isolation.Test Plan:
CI/CD