Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

This PR is part of V0 deprecation; To begin with, we will delete the hardware backends in vLLM V0 that has already been migrated to vLLM V1 (i.e., CPU, XPU, and TPU).

Copy link

github-actions bot commented Jul 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the tpu Related to Google TPUs label Jul 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @WoosukKwon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the deprecation of V0 hardware backends by removing the V0 implementation for the TPU backend. The changes streamline the codebase by eliminating legacy V0 paths, ensuring that the TPU backend exclusively utilizes the V1 architecture for attention, worker management, and other functionalities. This simplifies maintenance and aligns the TPU support with the newer V1 design.

Highlights

  • TPU Backend V0 Deprecation: The pull request removes the V0 implementation for the TPU backend, enforcing the exclusive use of the V1 architecture for all TPU operations.
  • Enforced V1 Pallas Attention Backend: The logic for selecting the attention backend on TPU has been simplified to unconditionally use vllm.v1.attention.backends.pallas.PallasAttentionBackend, eliminating the legacy V0 path.
  • V1 Worker Class Enforcement: The TPU worker class selection now defaults to vllm.v1.worker.tpu_worker.TPUWorker, removing the V0 worker and multi-step scheduling options previously available for TPU.
  • Removal of V0-Specific Checks: V0-specific conditional logic and imports related to asynchronous output support and guided decoding validation have been removed, streamlining the codebase and reducing complexity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to deprecate V0 backends, and the changes in vllm/platforms/tpu.py effectively remove the V0-specific logic for the TPU platform. The code has been simplified by removing conditional paths based on VLLM_USE_V1, making the V1 implementation the default and only path. The refactoring is clean, improves maintainability, and correctly reflects the goal of supporting only V1 for TPUs. I found no issues with the changes.

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon
Copy link
Collaborator Author

cc @jikunshang @yaochengji @bigPYJ1151

Could you please take a look?

Signed-off-by: Woosuk Kwon <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 3, 2025
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be tests still requires V0, which you can temporarily disable.

For example

docker exec cpu-test-"$NUMA_NODE" bash -c "
set -e
VLLM_USE_V1=0 pytest -s -v \
tests/quantization/test_ipex_quant.py"

cc @bigPYJ1151

Signed-off-by: Woosuk Kwon <[email protected]>
@bigPYJ1151
Copy link
Member

@WoosukKwon @simon-mo I will adapt the CPU part based on this PR to make the tests pass. BTW, will this PR be included in the incoming release?

Signed-off-by: Woosuk Kwon <[email protected]>
@mergify mergify bot added the ci/build label Jul 3, 2025
@jikunshang
Copy link
Collaborator

LGTM for xpu part. thanks!

@WoosukKwon
Copy link
Collaborator Author

will this PR be included in the incoming release?

@bigPYJ1151 Good question. Let me ask around.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 3, 2025
Copy link

mergify bot commented Jul 3, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@WoosukKwon WoosukKwon requested a review from tlrmchlsmth as a code owner July 3, 2025 15:05
@mergify mergify bot removed the needs-rebase label Jul 3, 2025
@WoosukKwon WoosukKwon moved this to In Progress in V0 Deprecation Jul 3, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon enabled auto-merge (squash) July 6, 2025 15:47
@WoosukKwon WoosukKwon disabled auto-merge July 6, 2025 15:47
@WoosukKwon WoosukKwon merged commit e202dd2 into main Jul 6, 2025
71 of 72 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/remove-v0-part1 branch July 6, 2025 15:48
@github-project-automation github-project-automation bot moved this from In Progress to Done in V0 Deprecation Jul 6, 2025
simon-mo added a commit that referenced this pull request Jul 6, 2025
vaibhavjainwiz pushed a commit to red-hat-data-services/vllm that referenced this pull request Jul 15, 2025
Sync to v0.9.2 + remove libsodium + [fix
cachetokeziner](neuralmagic/nm-vllm-ent@1423512)

git log:
```
commit 7b94527 (HEAD -> sync-v0.9.2, nm-fork/sync-v0.9.2)
Merge: 1423512 d07be8a
Author: Selbi Nuryyeva <[email protected]>
Date:   Fri Jul 11 07:03:51 2025 -0400

    Merge remote-tracking branch 'nm-fork/main' into sync-v0.9.2

commit 1423512
Author: Isotr0py <[email protected]>
Date:   Mon Jun 30 18:16:16 2025 +0800

    disable using CacheTokenizer for transformers >= 4.53.0
    
    fixes vllm-project#20224
    
    addendum to vllm-project#20244

commit d07be8a (nm-fork/main, nm-fork/HEAD)
Merge: bbccdbe 02152ad
Author: Daniele <[email protected]>
Date:   Wed Jul 9 15:18:56 2025 +0200

    Dockerfile*.ubi: remove libsodium (opendatahub-io#245)
    
    It's not needed anymore
    
    https://issues.redhat.com/browse/INFERENG-848

commit 7dd12da
Merge: bbccdbe a5dd03c
Author: Selbi Nuryyeva <[email protected]>
Date:   Tue Jul 8 10:08:37 2025 -0400

    Merge branch 'v0.9.2-upstream' into sync-v0.9.2

commit a5dd03c (tag: v0.9.2rc2, tag: v0.9.2, upstream/releases/v0.9.2, v0.9.2-upstream, upstream-v0.9.2)
Author: simon-mo <[email protected]>
Date:   Sun Jul 6 14:02:36 2025 -0700

    Revert "[V0 deprecation] Remove V0 CPU/XPU/TPU backends (vllm-project#20412)"
    
    This reverts commit e202dd2.

commit c18b3b8
Author: Cyrus Leung <[email protected]>
Date:   Mon Jul 7 05:01:48 2025 +0800

    [Bugfix] Add `use_cross_encoder` flag to use correct activation in `ClassifierPooler` (vllm-project#20527)
    
    Signed-off-by: DarkLight1337 <[email protected]>

commit 9528e3a
Author: Woosuk Kwon <[email protected]>
Date:   Sun Jul 6 12:44:52 2025 -0700

    [BugFix][Spec Decode] Fix spec token ids in model runner (vllm-project#20530)
    
    Signed-off-by: Woosuk Kwon <[email protected]>

commit 9fb52e5
Author: Cyrus Leung <[email protected]>
Date:   Mon Jul 7 00:54:36 2025 +0800

    [V1] Support any head size for FlexAttention backend (vllm-project#20467)
    
    Signed-off-by: DarkLight1337 <[email protected]>
```

Test:
CUDA: https://github.com/neuralmagic/nm-cicd/actions/runs/16218517666
ROCM: https://github.com/neuralmagic/nm-cicd/actions/runs/16218578391
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 23, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: jiang1.li <[email protected]>
Co-authored-by: Li, Jiang <[email protected]>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: jiang1.li <[email protected]>
Co-authored-by: Li, Jiang <[email protected]>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: jiang1.li <[email protected]>
Co-authored-by: Li, Jiang <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) performance Performance-related issues qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding structured-output tool-calling tpu Related to Google TPUs v1

Projects

Status: Done
Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants