-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Feature][EPLB] Add support for unquantized models #21168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Expert Parallelism Load Balancing (EPLB) to unquantized Mixture of Experts (MoE) models, which is a great enhancement. The changes look good overall.
My main feedback is on the use of assert
statements for input validation in vllm/model_executor/layers/fused_moe/layer.py
. While assert
is useful for internal sanity checks, it's not suitable for validating parameters in library code because assertions can be disabled in production environments. I've suggested replacing them with explicit checks that raise ValueError
or TypeError
to make the code more robust.
Please take a look at my detailed comments. Thanks for the contribution!
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: hsliu <[email protected]>
4f96014
to
fe75274
Compare
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: hsliu <[email protected]>
Signed-off-by: hsliu <[email protected]>
a604b32
to
7d56ab5
Compare
It looks like EPLB support for unquantized models has been implemented in #20775. Could you please confirm if that’s the case? |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
This PR aims to work with the long term todo with this PR: #18343
Add EPLB support for unquantized MoE model,
Test Plan
GPUs: 4 * A100-80G
Test Result
(Optional) Documentation Update