Skip to content

Conversation

hsliuustc
Copy link

@hsliuustc hsliuustc commented Jul 18, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

This PR aims to work with the long term todo with this PR: #18343
Add EPLB support for unquantized MoE model,

Test Plan

GPUs: 4 * A100-80G

vllm serve /workspace/models/DeepSeek-V2-Lite \
  --gpu-memory-utilization 0.85 \
  --tensor-parallel-size 4 \
  --enforce-eager  \
  --host 0.0.0.0 \
  --port 20001 \
  --enable-eplb \
  --enable-expert-parallel \
  --trust-remote-code \
curl -X POST http://127.0.0.1:20001/v1/completions  \
     -H "Content-Type: application/json" \
     -d '{
         "model": "/workspace/models/DeepSeek-V2-Lite",
         "prompt": ["Explain the theory of relativity in simple terms."],
         "max_tokens": 50,
         "temperature": 0.0,
         "top_p": 1,
         "top_k": 1
         }'

Test Result

image

(Optional) Documentation Update

@hsliuustc hsliuustc changed the title Eplb dequant mo e [Feature][EPLB] Add support for unquantized models Jul 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Expert Parallelism Load Balancing (EPLB) to unquantized Mixture of Experts (MoE) models, which is a great enhancement. The changes look good overall.

My main feedback is on the use of assert statements for input validation in vllm/model_executor/layers/fused_moe/layer.py. While assert is useful for internal sanity checks, it's not suitable for validating parameters in library code because assertions can be disabled in production environments. I've suggested replacing them with explicit checks that raise ValueError or TypeError to make the code more robust.

Please take a look at my detailed comments. Thanks for the contribution!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Jul 19, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hsliuustc.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 19, 2025
@mergify mergify bot removed the needs-rebase label Jul 19, 2025
@abmfy
Copy link
Member

abmfy commented Jul 29, 2025

It looks like EPLB support for unquantized models has been implemented in #20775. Could you please confirm if that’s the case?
Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants