[CI/Build] get rid of unused VLLM_FA_CMAKE_GPU_ARCHES #21599
Conversation
This variable is currently unused and is confusing Signed-off-by: Daniele Trifirò <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleanly removes the unused build argument VLLM_FA_CMAKE_GPU_ARCHES. The changes are applied consistently across the CI script, Dockerfiles, and documentation. The removal of this obsolete variable improves code clarity and maintainability. The changes are correct and I see no issues.
mergify
bot
added
documentation
dtrifiro
force-pushed
the
remove-deprecated-build-env-var
branch
from
fb9de49 to
330ef6a
Compare
|
cc @LucasWilkinson as discussed a few weeks ago 😅 |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@hmellor No, it's unused everywhere. You can grep for it in this repo and in flash-attention and it's not being used anywhere. See related PR in flash-attention repo here vllm-project/flash-attention#74 for more details. |
|
It does look like the failing image build is likely related though |
|
@hmellor nope: |
|
job restarted |
|
Oops, I mistook the unexpected size to be coming from our image, not a download |
github-actions
bot
added
the
ready
…1599) Signed-off-by: Daniele Trifirò <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: x22x22 <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]>
…1599) Signed-off-by: Daniele Trifirò <[email protected]>
This variable is currently unused and is confusing.
Related: vllm-project/flash-attention#74