Skip to content

Use float32 for test_completion.py #22385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Use float32 for test_completion.py #22385

merged 2 commits into from
Aug 7, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Aug 6, 2025 •
edited by github-actions bot
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 6, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 6, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request changes the data type from bfloat16 to float32 in test_completion.py to address a flaky test. The comment associated with this change needs to be updated to accurately reflect the current code and its purpose.

@mgoin
Update test_completion.py
9306fe6 
Signed-off-by: Michael Goin <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 6, 2025
tdoublep
tdoublep approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@tdoublep tdoublep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this test has been driving me crazy, thanks.

@tdoublep tdoublep mentioned this pull request Aug 6, 2025
Merged
4 tasks
@jeejeelee jeejeelee merged commit a00d8b2 into main Aug 7, 2025
30 checks passed
@jeejeelee jeejeelee deleted the test-completion-fp32 branch August 7, 2025 03:07
@russellb russellb mentioned this pull request Aug 8, 2025
Closed
3 tasks
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@mgoin @jinzhen-lin
Use float32 for test_completion.py (vllm-project#22385)
600f0f2 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@mgoin @noamgat
Use float32 for test_completion.py (vllm-project#22385)
6f708e0 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
wuhang2014 pushed a commit to wuhang2014/vllm that referenced this pull request Aug 12, 2025
@mgoin @wuhang2014
Use float32 for test_completion.py (vllm-project#22385)
3dafc16 
Signed-off-by: Michael Goin <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@mgoin @paulpak58
Use float32 for test_completion.py (vllm-project#22385)
4b9b5d2 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@mgoin @diegocastanibm
Use float32 for test_completion.py (vllm-project#22385)
eb99110 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@mgoin @epwalsh
Use float32 for test_completion.py (vllm-project#22385)
0a8f7a1 
Signed-off-by: Michael Goin <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@mgoin @amd-xiaoyu12
Use float32 for test_completion.py (vllm-project#22385)
c73d007 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@mgoin @zhewenl
Use float32 for test_completion.py (vllm-project#22385)
5e874ad 
Signed-off-by: Michael Goin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdoublep tdoublep tdoublep approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgoin @tdoublep @jeejeelee