Skip to content

Conversation

MMuzzammil1
Copy link

@MMuzzammil1 MMuzzammil1 commented Aug 9, 2025

Models trained using the EAGLE approach have fc.bias set to true by default https://github.com/SafeAILab/EAGLE/blob/main/eagle/model/cnets1.py#L473 (contrary to EAGLE3 where fc.bias is false https://github.com/SafeAILab/EAGLE/blob/main/eagle/model/cnets.py#L532). While this bug was fixed previously in the PR #8790, but it has crept in again.

Added the loading bias value from the config file.

Signed-off-by: Mohd Muzzammil <[email protected]>
Copy link

github-actions bot commented Aug 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added llama Related to Llama models speculative-decoding labels Aug 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a regression where the bias for the fully connected layer in EAGLE models was hardcoded to False. The change correctly loads the bias setting from the model's configuration file, ensuring that models like the original EAGLE which expect bias=True are loaded correctly. The use of getattr with a default value maintains backward compatibility. The fix is correct and well-implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llama Related to Llama models speculative-decoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant