-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[CI/Build] Skip Mllama HF runner tests with Transformers v4.55.0 #22659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a temporary fix to skip Mllama tests on Transformers v4.55.0 due to a regression, which is a good approach to keep the CI green. My main feedback is to refactor the duplicated pytest.mark.skipif
condition into a shared constant to improve code maintainability. This will make it easier to remove the skip condition once the upstream issue is resolved.
@pytest.mark.skipif( | ||
TRANSFORMERS_VERSION == "4.55.0", | ||
reason="Transformers v4.55.0 has a regression issue on mllama, " | ||
"see: https://github.com/huggingface/transformers/pull/40083") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and reduce code duplication, it's better to define this skipif
condition as a constant and reuse it for all affected tests. This will make it easier to remove the skip condition in the future when the upstream issue is resolved.
Please define the following constant at the top of the file, for example after the imports:
MMLAMA_REGRESSION_TRANSFORMERS_4_55_0 = pytest.mark.skipif(
TRANSFORMERS_VERSION == "4.55.0",
reason="Transformers v4.55.0 has a regression issue on mllama, "
"see: https://github.com/huggingface/transformers/pull/40083")
Then, you can apply it to this test and the others (test_models_multi_leading_images
, test_models_interleaved_images
, test_models_distributed
) like this:
@MMLAMA_REGRESSION_TRANSFORMERS_4_55_0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying the root cause!
…m-project#22659) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…m-project#22659) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…m-project#22659) Signed-off-by: Isotr0py <[email protected]>
…m-project#22659) Signed-off-by: Isotr0py <[email protected]>
…m-project#22659) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…m-project#22659) Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
Test should be skipped on CI now.
(Optional) Documentation Update