-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Bugfix][mamba] Fix type annotation of Mamba2Metadata #22787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Chen Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes several type annotation issues in Mamba2AttentionMetadata
by renaming some fields to be more specific to prefill operations and making them optional. The changes improve the clarity and correctness of the type hints. I've found one more minor type annotation issue in the same file that you might want to address as well.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I've been confused by which of these fields are used for what purpose in the past, and this will help next time.
…2787) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…2787) Signed-off-by: Chen Zhang <[email protected]>
…2787) Signed-off-by: Chen Zhang <[email protected]>
…2787) Signed-off-by: Chen Zhang <[email protected]>
…2787) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…2787) Signed-off-by: Chen Zhang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Fix some names and type annotation in Mamba2Metadata. All logic is unchanged. Prefer to get this PR in because people are copying these files to implement more mamba-like models in v1.
Test Plan
Test Result
match the previous result.
(Optional) Documentation Update