-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[Frontend] Complete Redesign of Tool Calling #22977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: chaunceyjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the tool calling JSON schema generation and introduces a new generic tool parser. My review identified a critical issue in protocol.py
where return
statements were missing, causing incorrect logic for tool choices. I've also found that the new GenericToolParser
has an incomplete streaming implementation with leftover debugging code. I've provided suggestions to fix these issues.
print(f"delta_text: {delta_text}") | ||
print(f"previous_text {previous_text} ") | ||
print(f"current_text {current_text} ") | ||
# delta = DeltaMessage(tool_calls=[ | ||
# DeltaToolCall(index=self.current_tool_id, | ||
# function=DeltaFunctionCall( | ||
# arguments=delta_text).model_dump( | ||
# exclude_none=True)) | ||
# ]) | ||
delta = DeltaMessage(content=delta_text) | ||
return delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This streaming implementation appears to be incomplete. It contains debugging print
statements that should be removed. The core logic for handling tool calls in streaming mode is commented out, and the function currently only streams back content, which will not work for tool calls. Additionally, most of the method's parameters are unused. I've suggested cleaning up the implementation to reflect its current capabilities.
print(f"delta_text: {delta_text}") | |
print(f"previous_text {previous_text} ") | |
print(f"current_text {current_text} ") | |
# delta = DeltaMessage(tool_calls=[ | |
# DeltaToolCall(index=self.current_tool_id, | |
# function=DeltaFunctionCall( | |
# arguments=delta_text).model_dump( | |
# exclude_none=True)) | |
# ]) | |
delta = DeltaMessage(content=delta_text) | |
return delta | |
# TODO: Implement streaming for tool calls. | |
# The current implementation only handles content streaming. | |
delta = DeltaMessage(content=delta_text) | |
return delta |
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Fix #22918
Purpose
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.