Skip to content

Upgrade xgrammar to 0.1.23 #22988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

russellb
Copy link
Member

Upgrade Xgrammar to 0.1.23, which includes some important fixes which allow us
to revert the workaround introduced by #19565.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades xgrammar to version 0.1.23 and reverts a workaround related to concurrent structured output requests. The changes are straightforward: the dependency version is updated in requirements/common.txt, and in vllm/v1/worker/gpu_model_runner.py, the code is simplified by removing the forced use of a specific xgrammar kernel implementation. This is done under the assumption that the new xgrammar version fixes the underlying issue, as stated in the pull request description. The code changes are consistent with this goal and appear correct. I have no further comments.

@Jialin
Copy link
Contributor

Jialin commented Aug 18, 2025

Sweet!

@russellb russellb requested a review from aarnphm August 19, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants