-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[BugFix] Fix stuck stats/metrics after requests are aborted #22995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue where scheduler statistics could get stuck if all requests in a step are aborted. The proposed change ensures that stats are always returned, even if there are no other engine outputs.
However, the implementation contains a critical bug related to operator precedence with the walrus operator (:=
). In its current form, the code will either raise an AttributeError
or cause a type error. I've provided a suggestion to fix this by adding the necessary parentheses to correctly capture the intended values before comparison.
Signed-off-by: Nick Hill <[email protected]>
8f5edce
to
dc3b867
Compare
Signed-off-by: Nick Hill <[email protected]>
Ensure that we always return new stats from scheduler.
Includes small fix to block pool to exclude null block when calculating cache usage percentage.
Fixes #22545.