Skip to content

[BugFix] Fix stuck stats/metrics after requests are aborted #22995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

njhill
Copy link
Member

@njhill njhill commented Aug 15, 2025

Ensure that we always return new stats from scheduler.

Includes small fix to block pool to exclude null block when calculating cache usage percentage.

Fixes #22545.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where scheduler statistics could get stuck if all requests in a step are aborted. The proposed change ensures that stats are always returned, even if there are no other engine outputs.

However, the implementation contains a critical bug related to operator precedence with the walrus operator (:=). In its current form, the code will either raise an AttributeError or cause a type error. I've provided a suggestion to fix this by adding the necessary parentheses to correctly capture the intended values before comparison.

@njhill njhill force-pushed the fix-abort-metrics branch from 8f5edce to dc3b867 Compare August 15, 2025 17:30
@njhill njhill marked this pull request as ready for review August 15, 2025 19:04
@njhill njhill marked this pull request as draft August 15, 2025 19:04
@njhill njhill marked this pull request as ready for review August 18, 2025 16:58
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Stats don't update to zero when all requests are aborted
1 participant