Skip to content

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Aug 26, 2025

Purpose

Update docs to reflect new status since #23299 was merged.

cc @heheda12345

Test Plan

n/a

Test Result

n/a


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@tdoublep tdoublep requested a review from hmellor as a code owner August 26, 2025 15:38
@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in docs/usage/v1_guide.md to remove the requirement of using the FlashInfer attention backend for certain hybrid models. This change is presented as a follow-up to a previous merge, making the framework more flexible by allowing other attention backends. I've reviewed the change and the surrounding code for hybrid models, and the update appears to be correct and consistent with a move towards broader backend support. The change is well-contained and clear.

@hmellor hmellor enabled auto-merge (squash) August 26, 2025 16:09
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 26, 2025
@hmellor hmellor merged commit 227e231 into vllm-project:main Aug 26, 2025
27 checks passed
tc-mb pushed a commit to tc-mb/vllm that referenced this pull request Aug 27, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants