-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[fix] lora benchmarks pass no_lora_flag_cpu #23774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] lora benchmarks pass no_lora_flag_cpu #23774
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Signed-off-by: Dylan Maloy <[email protected]> Signed-off-by: Dylan Maloy <[email protected]>
0d8b1a0
to
6c23808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this PR.
LGTM, thank you for contribution
Signed-off-by: Dylan Maloy <[email protected]> Co-authored-by: Jee Jee Li <[email protected]>
Signed-off-by: Dylan Maloy <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: Dylan Maloy <[email protected]> Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Dylan Maloy <[email protected]> Co-authored-by: Jee Jee Li <[email protected]>
Summary
FIX #25013
before
after