Skip to content

Conversation

ZJY0516
Copy link
Contributor

@ZJY0516 ZJY0516 commented Sep 9, 2025

Purpose

execute all compilation tests together
Link #24376 for visibility

Test Plan

pytest tests/compile/piecewise/

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the llama Related to Llama models label Sep 9, 2025
@ZJY0516 ZJY0516 marked this pull request as draft September 9, 2025 12:21
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors compilation tests to use unique library names for custom PyTorch ops, preventing conflicts when tests are run together. The approach of using Path(__file__).stem is a good way to ensure uniqueness. However, it's not robust to filenames containing hyphens, which would lead to invalid library names. I've suggested a small fix to sanitize the filenames to prevent future test failures.

@ZJY0516
Copy link
Contributor Author

ZJY0516 commented Sep 9, 2025

@ProExpertProg comparing PR #23257 with this approach, which do you prefer?

My thinking is: since only one attention type needs the internal counter, applying it everywhere seems a little strange.

Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
@mergify mergify bot added the ci/build label Sep 9, 2025
@ZJY0516 ZJY0516 changed the title [CI] execute all compilation tests together [CI] execute all piecewise compilation tests together Sep 9, 2025
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more complicated than necessary, I would just extract silly::attention into a common file and use it everywhere. #23257 does that roughly

@ProExpertProg
Copy link
Collaborator

@ZJY0516 just because others don't use the counter doesn't mean it has to be different. You can just think of the counter as always there and then some tests just don't use it. If there existed a silly::attention with a counter and you added a test that didn't need it, you wouldn't duplicate the op to create one without a counter, right?

@ZJY0516
Copy link
Contributor Author

ZJY0516 commented Sep 9, 2025

ok, I will implement it like #23257.

@ZJY0516 ZJY0516 marked this pull request as ready for review September 9, 2025 14:46
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, good cleanup. I also like calling the file silly_attention.py better than testing_ops.py in my PR!!

Signed-off-by: zjy0516 <[email protected]>
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comments

Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
@ProExpertProg ProExpertProg added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2025
@vllm-bot vllm-bot merged commit b8a9307 into vllm-project:main Sep 9, 2025
75 of 79 checks passed
@ZJY0516 ZJY0516 deleted the fix-compile-test branch September 10, 2025 03:06
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build llama Related to Llama models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants