-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Apply fixes for CUDA 13 #24599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes for CUDA 13 #24599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces fixes for building with CUDA 13 by abstracting CUB API differences into a new cub_helpers.h
header. The changes are well-implemented and consistently applied across all relevant CUDA kernel files. This is a good approach to handle version-specific API changes. I have one suggestion for CMakeLists.txt
to improve the robustness of how compiler flags are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from 1 nit, also Gemini suggestion is good. Did you try to build vLLM from source locally (pip install -e .) with cuda 13.0?
Yes, I did. I ran
|
Signed-off-by: Aidyn-A <[email protected]>
Signed-off-by: Aidyn-A <[email protected]>
Signed-off-by: Aidyn-A <[email protected]>
Signed-off-by: Aidyn-A <[email protected]>
Signed-off-by: Aidyn-A <[email protected]>
4d15ff5
to
17e8e05
Compare
No ciflow labels are configured for this repo. |
Signed-off-by: Aidyn-A <[email protected]>
Signed-off-by: Aidyn-A <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: Aidyn-A <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Aidyn-A <[email protected]>
Purpose
Fixes #24464 "Building vLLM with CUDA 13.0".
Test Plan
No plans. Just build.
Test Result
Test results must be the same as on CUDA 12.x.
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.