Skip to content

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Sep 11, 2025

Purpose

refactoring following #22992

Split pooling from entrypoints Test to Entrypoints Integration Test (Pooling) ~19 minutes

cc @DarkLight1337 @maxdebayser

Test Plan

pytest -v -s entrypoints/pooling

Test Result

keep ci green

Known Issues

entrypoints-integration-test-api-server still takes a long time ~1 hour, 49 minutes, we may need to split it further


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CI pipeline by splitting the pooling tests into a dedicated job. The file moves and import path updates are correct and improve the project structure. However, I've identified a potential issue with the new CI job's configuration: the timeout is set to a very high value of 130 minutes, which could impact CI performance and cost. I recommend reviewing this setting.

Signed-off-by: wang.yuqi <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 11, 2025 05:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 11, 2025
@vllm-bot vllm-bot merged commit a8b0361 into vllm-project:main Sep 11, 2025
76 of 80 checks passed
@noooop noooop deleted the split_entrypoints branch September 11, 2025 09:24
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants