Change log level from info to debug for IOProcessor #24999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this no-op log that print every time on startup now ``` (EngineCore_DP0 pid=1814976) INFO 09-16 22:06:03 [core.py:214] init engine (profile, create kv cache, warmup model) took 42.20 seconds INFO 09-16 22:06:04 [llm.py:295] Supported_tasks: ['generate'] INFO 09-16 22:06:04 [__init__.py:36] No IOProcessor plugins requested by the model ``` Signed-off-by: Michael Goin <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly changes a log message's level from info to debug within the IOProcessor plugin loading logic. This adjustment is for the common case where no IOProcessor plugin is requested, and it effectively reduces unnecessary log noise during application startup. The change is simple, well-motivated, and improves the overall user experience by making the logs cleaner. I have no further recommendations.
hmellor
approved these changes
Sep 17, 2025
tlrmchlsmth
approved these changes
Sep 17, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Michael Goin <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Michael Goin <[email protected]> Signed-off-by: charlifu <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Michael Goin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Michael Goin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove this no-op log that print every time on startup now
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.