Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

No description provided.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the vllm/engine/output_processor/util.py file, which contained the unused create_output_by_sequence_group utility function. This function was likely part of the now-deprecated multi-step scheduling logic, and its removal is a good cleanup that improves code maintainability. The change is correct and I have no concerns.

@WoosukKwon WoosukKwon merged commit 99cc41a into main Sep 17, 2025
54 of 59 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/remove-unused-util branch September 17, 2025 16:50
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant