Skip to content

Remove unused find_cuda_init helper script #25044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Remove unused find_cuda_init helper script #25044

merged 1 commit into from
Sep 17, 2025

Conversation

simon-mo
Copy link
Collaborator

Summary

  • remove the unused find_cuda_init.py debugging helper script, along with its references

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_68ca528499348329a12987ba5d883a29

@simon-mo simon-mo requested a review from ywang96 September 17, 2025 06:26
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unused debugging helper script, find_cuda_init.py. This is a good code hygiene practice that improves maintainability by removing dead code. The change is straightforward and correct. I approve.

@simon-mo
Copy link
Collaborator Author

We don't need this file anymore. Especially in root dir.

@simon-mo simon-mo merged commit d6a518f into main Sep 17, 2025
19 of 21 checks passed
@simon-mo simon-mo deleted the codex/remove-find_cuda.py-and-references branch September 17, 2025 16:47
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@simon-mo @FeiDaLI
Remove unused find_cuda_init helper script (vllm-project#25044)
a9dd911
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@simon-mo @charlifu
Remove unused find_cuda_init helper script (vllm-project#25044)
e13c47b 
Signed-off-by: charlifu <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@simon-mo @xuebwang-amd
Remove unused find_cuda_init helper script (vllm-project#25044)
c656cfa 
Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@simon-mo @choprahetarth
Remove unused find_cuda_init helper script (vllm-project#25044)
89e141a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywang96 ywang96 Awaiting requested review from ywang96

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@simon-mo