-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Docs] Fix griffe warnings in vllm/lora/ops #25369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: windsonsea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses several griffe
warnings by correcting docstrings in vllm/lora/ops/triton_ops/lora_kernel_metadata.py
and vllm/lora/ops/xla_ops/lora_ops.py
. The changes correctly align parameter names in docstrings with their corresponding function signatures and fix indentation issues that were causing parsing failures. The modifications are accurate and effectively resolve the reported warnings. As the changes are correct and do not contain any issues of high or critical severity, I have no specific comments to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: gaojc <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Fix these warnings:
Related to issue #25020