Skip to content

Conversation

windsonsea
Copy link
Contributor

@windsonsea windsonsea commented Sep 22, 2025

Fix these warnings:

WARNING - griffe: vllm/lora/ops/triton_ops/lora_kernel_metadata.py:138:
Failed to get 'name: description' pair from 'pass.'

WARNING - griffe: vllm/lora/ops/triton_ops/lora_kernel_metadata.py:86:
Failed to get 'name: description' pair from 'for each input token.'

WARNING - griffe: vllm/lora/ops/triton_ops/lora_kernel_metadata.py:85:
Parameter 'token_lora_tensor' does not appear in the function signature

WARNING - griffe: vllm/lora/ops/xla_ops/lora_ops.py:95:
Parameter 'output_tensor' does not appear in the function signature

Related to issue #25020

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses several griffe warnings by correcting docstrings in vllm/lora/ops/triton_ops/lora_kernel_metadata.py and vllm/lora/ops/xla_ops/lora_ops.py. The changes correctly align parameter names in docstrings with their corresponding function signatures and fix indentation issues that were causing parsing failures. The modifications are accurate and effectively resolve the reported warnings. As the changes are correct and do not contain any issues of high or critical severity, I have no specific comments to add.

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 23, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) September 23, 2025 02:21
@jeejeelee jeejeelee merged commit fafbe11 into vllm-project:main Sep 23, 2025
58 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
gjc0824 pushed a commit to gjc0824/vllm that referenced this pull request Oct 10, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants