-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Model] Enable DP for ViT in Qwen2-VL #25445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Enable DP for ViT in Qwen2-VL #25445
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces data parallelism support for the Vision Transformer in Qwen2-VL. The changes are well-structured and primarily involve plumbing a use_data_parallel
flag through the vision model components to conditionally disable tensor parallelism. The logic for handling data-parallel execution paths appears correct. Overall, the changes are sound and should enable the intended data parallelism functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: charlifu <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: gaojc <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Purpose
Part of #22743
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.