-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CI] Add Blackwell LM Eval Small Models test to nightly #26052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new nightly Buildkite test for LM evaluation on small models on Blackwell GPUs. I've found a critical issue with incorrect file paths in the test command which will cause the test to fail. I've also identified that the source file dependencies for the new test step are incomplete, which would prevent it from being triggered on relevant code changes. I've provided suggestions to fix both issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…#26052) Signed-off-by: mgoin <[email protected]> Signed-off-by: Karan Goel <[email protected]>
…#26052) Signed-off-by: mgoin <[email protected]>
…#26052) Signed-off-by: mgoin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Purpose
This will help catch clear gsm8k regressions like #26049
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.