Skip to content

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 1, 2025

Purpose

This will help catch clear gsm8k regressions like #26049

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Oct 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new nightly Buildkite test for LM evaluation on small models on Blackwell GPUs. I've found a critical issue with incorrect file paths in the test command which will cause the test to fail. I've also identified that the source file dependencies for the new test step are incomplete, which would prevent it from being triggered on relevant code changes. I've provided suggestions to fix both issues.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 1, 2025
@mgoin mgoin changed the title Add Blackwell LM Eval Small Models test to nightly [CI] Add Blackwell LM Eval Small Models test to nightly Oct 1, 2025
Copy link
Contributor

@pavanimajety pavanimajety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgoin mgoin merged commit 60bc25e into vllm-project:main Oct 5, 2025
18 checks passed
@mgoin mgoin deleted the blackwell-lm-eval branch October 5, 2025 20:59
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants