[Misc] [CI/Build] [CMake] PTX Warning #26101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing this issue: #9129 This implements a warning for PTX version and also a local-editable test. Signed-off-by: nadathurv <[email protected]>
Add actions/cache for ~/.cache/pip and ~/.cache/torch_extensions and max jobs =2 to be generous Signed-off-by: nadathurv <[email protected]> Co-Authored-By: Srreyansh Sethi <[email protected]>
ghost
requested review from
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a warning for unsupported +PTX builds in the global TORCH_CUDA_ARCH_LIST and adds a CI test for local builds. The change in CMakeLists.txt correctly identifies the presence of +PTX and issues a warning.
My review focuses on improving the robustness of the check in CMakeLists.txt. I've suggested a change to prevent potential false-positive warnings, which can improve the developer experience by keeping the build output clean and relevant.
added 4 commits
October 2, 2025 08:13
Prevent false-positives. Fix CPU editable test. Signed-off-by: nadathurv <[email protected]>
Signed-off-by: nadathurv <[email protected]>
Signed-off-by: nadathurv <[email protected]>
ghost
changed the title
zhuohan123
approved these changes
Oct 2, 2025
github-actions
bot
added
the
ready
|
@zhuohan123 @DarkLight1337 CI check fails seems unrelated. Can this be merged? Thanks |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing this issue: #9129 Just adding a warning
cc @LucasWilkinson
@WorldExplored