Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Oct 3, 2025

This PR solves 2 problems that enables expert parallel in the Transformers backend:

  • Ensures that the dtypes of topk_ids (torch.int32) and topk_weights (torch.float32) match what is expected from FusedMoE.select_experts
  • Gathers the topk_ids which are passed directly from Transformers as is done for the hidden_states and topk_weights automatically inside FusedMoE

Signed-off-by: Harry Mellor <[email protected]>
@hmellor hmellor marked this pull request as ready for review October 3, 2025 11:22
@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 3, 2025
@hmellor hmellor requested a review from Isotr0py October 3, 2025 13:37
@Isotr0py Isotr0py enabled auto-merge (squash) October 4, 2025 02:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 4, 2025
@Isotr0py Isotr0py merged commit d3d649e into vllm-project:main Oct 4, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Transformers backend Oct 4, 2025
@hmellor hmellor deleted the transformers-backend-ep branch October 4, 2025 07:37
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Tomer Asida <[email protected]>
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Karan Goel <[email protected]>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants