[Misc] Remove unused executor.apply_model
#26215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
22quinn,
alexm-redhat,
comaniac,
njhill,
youkaichao and
zhuohan123
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated apply_model method from ExecutorBase and its associated unused imports. This change is a straightforward cleanup of dead code, which is appropriate given that the V0 API is no longer in use. The removal appears correct and self-contained. I have no further feedback.
simon-mo
approved these changes
Oct 4, 2025
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Tomer Asida <[email protected]>
karan
pushed a commit
to karan/vllm
that referenced
this pull request
Oct 6, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Karan Goel <[email protected]>
southfreebird
pushed a commit
to southfreebird/vllm
that referenced
this pull request
Oct 7, 2025
Signed-off-by: DarkLight1337 <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
V0 has been removed, so this method is just dead code.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.