-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Support block size 32 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
tianyil1
pushed a commit
to tianyil1/vllm
that referenced
this pull request
Jun 5, 2024
fxmarty
pushed a commit
to fxmarty/vllm-public
that referenced
this pull request
Jun 12, 2024
…ge_with_newer_pytorch Update base docker image with Pytorch 2.3
joerunde
added a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
…ch instead. (vllm-project#35) I tested the previous fix for the Triton cache collision issue (see: vllm-project#34) and it didn't work. I now see errors like: ``` FileNotFoundError: [Errno 2] No such file or directory: '/home/vllm/.triton/cache/1feb415f3280ca46eea8c4407a58c23e/fused_moe_kernel.json.tmp.pid_72_c0a0033e-6147-4520-ae3a-3847d02598f8' ``` which now shows the `uuid` instead of a random integer, but problem remains. This PR implements a different workaround, proposed by @cyang49, that tells Triton to use a custom cache manager which assigns a different directory based on the process id. This time I have tested it and it seems to work. --------- Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Joe Runde <[email protected]> Co-authored-by: Chih-Chieh-Yang <[email protected]> Co-authored-by: Joe Runde <[email protected]> Co-authored-by: Nick Hill <[email protected]>
bigPYJ1151
pushed a commit
to bigPYJ1151/vllm
that referenced
this pull request
Jul 30, 2024
…wq_gptq_autoround
Closed
1 task
1 task
1 task
1 task
Bounty-hunter
added a commit
to Bounty-hunter/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: dengyunyang <[email protected]> Co-authored-by: dengyunyang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for block size 32. It turns out that no modification to our attention kernel is required for this support.