[Bugfix][CI/Build] Fix test and improve code for merge_async_iterators
#5096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkLight1337
changed the title
merge_async_iterators code and testsmerge_async_iterators code and tests
DarkLight1337
changed the title
merge_async_iterators code and testsmerge_async_iterators code and tests
5 tasks
DarkLight1337
changed the title
merge_async_iterators code and testsmerge_async_iterators
simon-mo
approved these changes
May 29, 2024
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm
that referenced
this pull request
May 31, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 31, 2024
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm
that referenced
this pull request
Jun 6, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 8, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
merge_async_iteratorstests cannot be run inpython<3.10due to lack ofanextbuiltin. It also moves the test to a more appropriate location (test_utils.py).Functionality-wise, this PR enables async tasks in
merge_async_iteratorsto be cancelled with a message starting frompython>=3.9where it is supported.Related contributions
This is part 1/5 of #5004.