Skip to content

[Bugfix] fix missing last itl in openai completions benchmark #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2024
Merged

[Bugfix] fix missing last itl in openai completions benchmark #5926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f047d73
capture final itl
mcalman Jun 27, 2024
cc9b085
Run yapf and ruff
mcalman Jun 27, 2024
548fedd
Merge branch 'main' into itl-bugfix
mcalman Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions benchmarks/backend_request_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ async def async_request_openai_completions(
else:
data = json.loads(chunk)

# NOTE: Some completion API might have a last
# usage summary response without a token so we
# want to check a token was generated
if data["choices"][0]["text"]:
timestamp = time.perf_counter()
# First token
Expand All @@ -273,12 +276,8 @@ async def async_request_openai_completions(
output.ttft = ttft

# Decoding phase
# NOTE: Some completion API might have a last
# usage summary response without a token so we
# do not want to include as inter-token-latency
elif data.get("usage", None) is None:
output.itl.append(timestamp -
most_recent_timestamp)
output.itl.append(timestamp -
most_recent_timestamp)

most_recent_timestamp = timestamp
generated_text += data["choices"][0]["text"]
Expand Down