Skip to content

[BugFix] Ensure worker model loop is always stopped at the right time #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[BugFix] Ensure worker model loop is always stopped at the right time #5987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c80f79
[BugFix] Ensure worker model loop is always stopped at the right time
njhill Jun 29, 2024
87c5226
Revert AsyncLLMEngine change
njhill Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/engine/llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ def step(self) -> List[Union[RequestOutput, EmbeddingRequestOutput]]:
# Tracing
self.do_tracing(scheduler_outputs)

if not request_outputs:
if not self.has_unfinished_requests():
# Stop the execute model loop in parallel workers until there are
# more requests to process. This avoids waiting indefinitely in
# torch.distributed ops which may otherwise timeout, and unblocks
Expand Down