Skip to content

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Jul 15, 2024

Related to #6434

@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run).

Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo simon-mo requested a review from WoosukKwon July 15, 2024 03:15
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any PR to be merged before the release?

@WoosukKwon
Copy link
Collaborator

We might want to merge #6140 before the release. Currently, Mixtral doesn't work on my machine because of the Triton cache issue and the PR fixes the bug.

@simon-mo simon-mo enabled auto-merge (squash) July 15, 2024 17:13
@simon-mo simon-mo merged commit 64fdc08 into vllm-project:main Jul 15, 2024
@g-eoj
Copy link
Contributor

g-eoj commented Jul 15, 2024

The link for the soft tuned prompts pr is wrong in the highlights: https://github.com/vllm-project/vllm/releases/tag/v0.5.2

@simon-mo
Copy link
Collaborator Author

Thanks. Fixed. It should be #4645

xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants