Fix a bug in attention kernel #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yukavio
pushed a commit
to yukavio/vllm
that referenced
this pull request
Jul 3, 2024
SUMMARY: - Added `licenses` subfolder for directories - Moved `LICENSE-apache` into `licenses` directory - Updated `setup.py` with NM Community License TEST PLAN: None
dllehr-amd
pushed a commit
to dllehr-amd/vllm
that referenced
this pull request
Jul 22, 2024
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Aug 15, 2024
maxdebayser
pushed a commit
to maxdebayser/vllm
that referenced
this pull request
Feb 13, 2025
…ncies (vllm-project#68) I already tried to fix this using IBM/vllm#66 but upstream didn't like that change (the behaviour to filter out comments containing torch was intentional). After [some discussion](vllm-project#12255), we agreed on a different solution implemented in this PR. Note that I reverted the changes from vllm-project#66 by force pushing main. Note this has already been merged upstream by vllm-project#12260 but I'm cherry-picking the fix here since it is blocking the CI builds.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
This PR fixes a bug in our attention kernel. The bug was introduced in #53 when changing the precision of computations in the attention kernel. Now the kernel unit tests are passed normally.