Skip to content

[misc][ci] fix quant test #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2024
Merged

[misc][ci] fix quant test #8449

merged 4 commits into from
Sep 13, 2024

Conversation

youkaichao
Copy link
Member

these will init cuda and make tp tests fail.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Sep 13, 2024
View reviewed changes
@youkaichao youkaichao mentioned this pull request Sep 13, 2024
Merged
youkaichao
youkaichao commented Sep 13, 2024
View reviewed changes
tests/quantization/utils.py

def is_quant_method_supported(quant_method: str) -> bool:
# Currently, all quantization methods require Nvidia or AMD GPUs
if not torch.cuda.is_available():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hate torch.cuda.is_available() . @DarkLight1337 if you have time, please change all occurrence to avoid accidentally initializing cuda.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this in another PR.

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 13, 2024
@DarkLight1337 DarkLight1337 merged commit a246912 into vllm-project:main Sep 13, 2024
46 checks passed
@youkaichao youkaichao deleted the fix_quant_test branch September 13, 2024 15:54
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Sep 16, 2024
@youkaichao @dtrifiro
[misc][ci] fix quant test (vllm-project#8449)
07afc6d
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@youkaichao @Alvant
[misc][ci] fix quant test (vllm-project#8449)
a789399 
Signed-off-by: Alvant <[email protected]>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@youkaichao @garg-amit
[misc][ci] fix quant test (vllm-project#8449)
4128ef8 
Signed-off-by: Amit Garg <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@youkaichao @LeiWang1999
[misc][ci] fix quant test (vllm-project#8449)
42efb6e 
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youkaichao @DarkLight1337